Yohahaha commented on code in PR #5456:
URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1571943131
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -1211,7 +1211,7 @@ object GlutenConfig {
.internal()
.doc("The IO threads for connector split preloading")
.intConf
- .createWithDefault(0)
+ .createWithDefaultFunction(() =>
SQLConf.get.getConfString("spark.executor.cores", "1").toInt)
Review Comment:
may I ask why use spark.executor.cores as default values? why not set 2 to
align with Velox?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
