gaoyangxiaozhu commented on code in PR #3978:
URL: https://github.com/apache/incubator-gluten/pull/3978#discussion_r1574564412
##########
cpp/velox/operators/writer/VeloxParquetDatasource.h:
##########
@@ -54,12 +58,14 @@ class VeloxParquetDatasource final : public Datasource {
const std::string& filePath,
std::shared_ptr<facebook::velox::memory::MemoryPool> veloxPool,
std::shared_ptr<facebook::velox::memory::MemoryPool> s3SinkPool,
+ std::shared_ptr<facebook::velox::memory::MemoryPool> gcsSinkPool,
std::shared_ptr<arrow::Schema> schema)
: Datasource(filePath, schema),
filePath_(filePath),
schema_(schema),
pool_(std::move(veloxPool)),
- s3SinkPool_(std::move(s3SinkPool)) {}
+ s3SinkPool_(std::move(s3SinkPool)),
+ gcsSinkPool_(std::move(gcsSinkPool)) {}
Review Comment:
I need to onboard `ABFS write` part native support , @FelixYBW / @tigrux ,
so i make a refactor PR to address this comment
https://github.com/apache/incubator-gluten/pull/5486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
