gaoyangxiaozhu commented on code in PR #5486:
URL: https://github.com/apache/incubator-gluten/pull/5486#discussion_r1575880297
##########
cpp/velox/operators/writer/VeloxParquetDatasource.h:
##########
@@ -51,20 +51,31 @@
namespace gluten {
-class VeloxParquetDatasource final : public Datasource {
+inline bool isSupportedS3SdkPath(const std::string& filePath_) {
+ // support scheme
+ const std::array<const char*, 5> supported_schemes = {"s3:", "s3a:", "oss:",
"cos:", "cosn:"};
+
+ for (const char* scheme : supported_schemes) {
+ size_t scheme_length = std::strlen(scheme);
+ if (filePath_.length() >= scheme_length && std::strncmp(filePath_.c_str(),
scheme, scheme_length) == 0) {
+ return true;
+ }
+ }
+ return false;
+}
+
+inline bool isSupportedGCSPath(const std::string& filePath_) {
+ return strncmp(filePath_.c_str(), "gs:", 3) == 0;
+}
+
+class VeloxParquetDatasource : public Datasource {
Review Comment:
sure, let me do the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
