marin-ma commented on code in PR #5495:
URL: https://github.com/apache/incubator-gluten/pull/5495#discussion_r1579022639
##########
cpp/velox/udf/examples/MyUDF.cc:
##########
@@ -21,15 +21,29 @@
#include <iostream>
#include "udf/Udf.h"
-namespace {
-
using namespace facebook::velox;
using namespace facebook::velox::exec;
static const char* kInteger = "int";
static const char* kBigInt = "bigint";
static const char* kDate = "date";
+class UdfRegisterer {
Review Comment:
The naming of registerer is the object who is used to/resposible for
registering functions. There is also similar naming in Velox.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
