zhztheplayer commented on code in PR #5462:
URL: https://github.com/apache/incubator-gluten/pull/5462#discussion_r1579075547
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformHintRule.scala:
##########
@@ -502,9 +502,20 @@ case class AddTransformHintRule() extends Rule[SparkPlan] {
plan.generatorOutput,
plan.child)
transformer.doValidate().tagOnFallback(plan)
- case plan: EvalPythonExec =>
+ case plan: BatchEvalPythonExec =>
val transformer = EvalPythonExecTransformer(plan.udfs,
plan.resultAttrs, plan.child)
transformer.doValidate().tagOnFallback(plan)
+ case plan: ArrowEvalPythonExec =>
+ if (
+ !BackendsApiManager.getSettings.supportColumnarArrowUdf() ||
+ GlutenConfig.getConf.enableColumnarArrowUDF
+ ) {
Review Comment:
No need to add to validator code. Seems to be that we don't do switch-based
fallback on both `BatchEvalPythonExec` and `ArrowEvalPythonExec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
