marin-ma commented on code in PR #5536: URL: https://github.com/apache/incubator-gluten/pull/5536#discussion_r1580320425
########## cpp/velox/shuffle/VeloxShuffleWriter.cc: ########## @@ -892,6 +909,8 @@ uint32_t VeloxShuffleWriter::calculatePartitionBufferSize(const facebook::velox: totalInputNumRows_ += numRows; + maxBatchSize_ = preAllocRowCnt == 0 ? numPartitions_ : preAllocRowCnt * numPartitions_; Review Comment: Why adding 'numPartitions_` here? Could you add some comments here for this calculation? ########## cpp/velox/shuffle/VeloxShuffleWriter.cc: ########## @@ -892,6 +909,8 @@ uint32_t VeloxShuffleWriter::calculatePartitionBufferSize(const facebook::velox: totalInputNumRows_ += numRows; + maxBatchSize_ = preAllocRowCnt == 0 ? numPartitions_ : preAllocRowCnt * numPartitions_; Review Comment: Why adding `numPartitions_` here? Could you add some comments here for this calculation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
