zhztheplayer commented on code in PR #5552:
URL: https://github.com/apache/incubator-gluten/pull/5552#discussion_r1581976016
##########
gluten-core/src/main/scala/org/apache/gluten/planner/cost/GlutenCostModel.scala:
##########
@@ -52,22 +55,26 @@ object GlutenCostModel {
}
// A very rough estimation as of now.
- private def selfLongCostOf(node: SparkPlan): Long = node match {
- case ColumnarToRowExec(child) => 3L
- case RowToColumnarExec(child) => 3L
- case ColumnarTransitions.ColumnarToRowLike(child) => 3L
- case ColumnarTransitions.RowToColumnarLike(child) => 3L
- case p if PlanUtil.isGlutenColumnarOp(p) => 2L
- case p if PlanUtil.isVanillaColumnarOp(p) => 3L
- // Other row ops. Usually a vanilla row op.
- case _ => 5L
+ private def selfLongCostOf(node: SparkPlan): Long = {
+ node match {
+ case p: ShuffledHashJoinExec if !TransformJoin.isLegal(p) =>
+ infLongCost
Review Comment:
doc needed here
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformSingleNode.scala:
##########
@@ -237,6 +223,20 @@ case class TransformJoin() extends TransformSingleNode
with LogLevelUtil {
}
+object TransformJoin {
+ private def getSparkSupportedBuildSide(plan: ShuffledHashJoinExec):
BuildSide = {
Review Comment:
doc needed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
