yma11 commented on issue #4652: URL: https://github.com/apache/incubator-gluten/issues/4652#issuecomment-2083951216
> > @FelixYBW This fix should be done at cpp side. The formal fix is in [PR](https://github.com/apache/incubator-gluten/pull/5544). Can you help review it? > > Is it a Gluten issue? I'd think veox has some bug here. Yes. I think so. It's caused by the additional projects we added before/after shuffle. The logic of partial/final handle in Velox upstream has no problem. The ideal way is to add struct support for shuffle in Gluten so that we can remove the hack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
