liuneng1994 commented on code in PR #5529:
URL: https://github.com/apache/incubator-gluten/pull/5529#discussion_r1584296318
##########
cpp-ch/local-engine/Common/CHUtil.h:
##########
@@ -32,6 +32,10 @@
namespace local_engine
{
+static const std::unordered_set<String>
bool_value_settings{"mergetree.merge_after_insert"};
Review Comment:
常量用大写字母
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
