yma11 commented on issue #5511:
URL:
https://github.com/apache/incubator-gluten/issues/5511#issuecomment-2095049818
Hi binwei,
I have met the same issue when I deployed parquet read fuzzer test. This is
caused by different compile flag used in Gluten --- "-march=native -std=c++17
-mno-avx512f -mbmi2 $ADDITIONAL_FLAGS" thus velox upstream doesn’t have this
issue. Another optional fix is to add “-Wno-stringop-overflow” but it will
cover the errors which should be caught.
Thanks,
Yan
From: BInwei Yang ***@***.***>
Sent: Monday, May 6, 2024 5:06 AM
To: apache/incubator-gluten ***@***.***>
Cc: Ma, Yan ***@***.***>; Author ***@***.***>
Subject: Re: [apache/incubator-gluten] GCC 11 warns that writing 1 byte into
a region of size 0 [-Wstringop-overflow=] (Issue #5511)
A quick fix to hack Velox code:
void clearAll() {
bits::fillBits(bits_.data(), 0, size_, false);
begin_ = 0;
end_ = 0;
#pragma GCC diagnostic ignored "-Wstringop-overflow"
allSelected_ = false;
#pragma GCC diagnostic pop
}
/**
* Sets the vector to all selected.
*/
void setAll() {
bits::fillBits(bits_.data(), 0, size_, true);
begin_ = 0;
end_ = size_;
#pragma GCC diagnostic ignored "-Wstringop-overflow"
allSelected_ = true;
#pragma GCC diagnostic pop
}
What GCC version does Velox use? why they can compile?
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/incubator-gluten/issues/5511#issuecomment-2094950416>,
or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AC2M2YGM72OB4GDXBA5VXBTZA2NK7AVCNFSM6AAAAABGV5BI6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUHE2TANBRGY>.
You are receiving this because you authored the thread.Message ID:
***@***.******@***.***>>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
