ulysses-you commented on code in PR #5575:
URL: https://github.com/apache/incubator-gluten/pull/5575#discussion_r1590637554
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -60,6 +60,12 @@ abstract class HashAggregateExecTransformer(
resultExpressions,
child) {
+ override def output: Seq[Attribute] = {
+ // TODO: We should have a check to make sure the returned schema actually
matches the output
+ // data. Since "resultExpressions" is not actually in used by Velox.
+ super.output
Review Comment:
Why do we need to highlight this, did not we add post project with
`resultExpressions` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
