yma11 commented on code in PR #5624:
URL: https://github.com/apache/incubator-gluten/pull/5624#discussion_r1591701775
##########
gluten-iceberg/src/main/scala/org/apache/iceberg/spark/source/GlutenIcebergSourceUtil.scala:
##########
@@ -94,15 +97,24 @@ object GlutenIcebergSourceUtil {
throw new GlutenNotSupportException("Only support iceberg
SparkBatchQueryScan.")
}
- def getPartitionSchema(sparkScan: Scan): StructType = sparkScan match {
+ def getReadPartitionSchema(sparkScan: Scan): StructType = sparkScan match {
Review Comment:
Maybe rename to `getReferredPartitionSchema` to indicates that we only
retrieve the partition schemas referred by the query?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
