Yohahaha commented on issue #5611:
URL: 
https://github.com/apache/incubator-gluten/issues/5611#issuecomment-2097372272

   > > I think this function is the issue.
   > > 
https://github.com/apache/incubator-gluten/blob/fea47053c9716ad1cc2433403312b348889ca959/cpp/velox/memory/VeloxMemoryManager.cc#L94-L108
   > 
   > Thanks for catching! I didn't check if it's related to this issue but it 
looks like my mistake missing a return statement in the code you mentioned.
   > 
   > Would you like to make a fix for it? Thanks!
   
   I have fixed and verified in our internal case, but there exists another 
issue for high peak memory 
https://github.com/apache/incubator-gluten/issues/5630.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to