liuneng1994 commented on code in PR #5455: URL: https://github.com/apache/incubator-gluten/pull/5455#discussion_r1592014810
########## cpp-ch/local-engine/Functions/FunctionGetDateData.h: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include <Common/LocalDate.h> +#include <Common/DateLUT.h> +#include <Common/DateLUTImpl.h> +#include <Columns/ColumnString.h> +#include <Columns/ColumnVector.h> +#include <Columns/ColumnNullable.h> +#include <DataTypes/DataTypeNullable.h> +#include <Functions/FunctionFactory.h> +#include <IO/ReadBufferFromMemory.h> +#include <IO/ReadHelpers.h> +#include <IO/parseDateTimeBestEffort.h> + +using namespace DB; + +namespace DB +{ +namespace ErrorCodes +{ + extern const int ILLEGAL_TYPE_OF_ARGUMENT; + extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH; +} +} + +namespace local_engine +{ +template<bool get_year, bool get_date, typename T> +class FunctionGetDateData : public DB::IFunction +{ +public: + FunctionGetDateData() = default; + ~FunctionGetDateData() override = default; + bool checkAndGetDateData(DB::ReadBuffer & buf, size_t buf_size, T &x, const DateLUTImpl & date_lut, UInt8 & can_be_parsed) const + { + auto checkNumbericASCII = [&](DB::ReadBuffer & rb, size_t start, size_t length) -> bool + { + for (size_t i = start; i < start + length; ++i) + { + if (!isNumericASCII(*(rb.position() + i))) + { + return false; + } + } + return true; + }; + auto checkDelimiter = [&](DB::ReadBuffer & rb, size_t pos) -> bool + { + if (*(rb.position() + pos) != '-') + return false; + else + return true; + }; + bool yearNumberCanbeParsed = checkNumbericASCII(buf, 0, 4) && (buf_size == 4 || checkDelimiter(buf, 4)); + Int16 year = 0; + if (yearNumberCanbeParsed) + { + year = (*(buf.position() + 0) - '0') * 1000 + + (*(buf.position() + 1) - '0') * 100 + + (*(buf.position() + 2) - '0') * 10 + + (*(buf.position() + 3) - '0'); + x = get_year ? year : 0; + } + if (!yearNumberCanbeParsed + || !checkNumbericASCII(buf, 5, 2) + || !checkDelimiter(buf, 7) + || !checkNumbericASCII(buf, 8, 2)) + { + can_be_parsed = yearNumberCanbeParsed; + return false; + } + else + { + UInt8 month = (*(buf.position() + 5) - '0') * 10 + (*(buf.position() + 6) - '0'); + if (month <= 0 || month > 12) + return false; + UInt8 day = (*(buf.position() + 8) - '0') * 10 + (*(buf.position() + 9) - '0'); + if (day <= 0 || day > 31) + return false; + else if (day == 31 && (month == 2 || month == 4 || month == 6 || month == 9 || month == 11)) + return false; + else if (day == 30 && month == 2) + return false; + else + { + if (day == 29 && month == 2 && year % 4 != 0) + return false; + else + { + if (get_date) + x = date_lut.makeDayNum(year, month, day, -static_cast<Int32>(date_lut.getDayNumOffsetEpoch())); + return true; + } + } + } + } + + DB::ColumnPtr executeImpl(const DB::ColumnsWithTypeAndName & arguments, const DB::DataTypePtr & result_type, size_t) const override + { + if (arguments.size() != 1) + throw DB::Exception(DB::ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {}'s arguments number must be 1.", getName()); + + const DB::ColumnWithTypeAndName arg1 = arguments[0]; + const auto * src_col = checkAndGetColumn<DB::ColumnString>(arg1.column.get()); + size_t size = src_col->size(); + + if (!result_type->isNullable()) + throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {}'s return type must be nullable", getName()); + + using ColVecTo = ColumnVector<T>; + typename ColVecTo::MutablePtr result_column = ColVecTo::create(size, 0); + typename ColVecTo::Container & result_container = result_column->getData(); + DB::ColumnUInt8::MutablePtr null_map = DB::ColumnUInt8::create(size, 0); + typename DB::ColumnUInt8::Container & null_container = null_map->getData(); + const DateLUTImpl * local_time_zone = &DateLUT::instance(); + const DateLUTImpl * utc_time_zone = &DateLUT::instance("UTC"); + + for (size_t i = 0; i < size; ++i) + { + auto str = src_col->getDataAt(i); + if (str.size < 4) + { + null_container[i] = true; + continue; + } + else + { + DB::ReadBufferFromMemory buf(str.data, str.size); + while(!buf.eof() && *buf.position() == ' ') + { + buf.position() ++; + } + if(buf.buffer().end() - buf.position() < 4) + { + null_container[i] = true; + continue; + } + UInt8 can_be_parsed = 1; Review Comment: use bool ########## cpp-ch/local-engine/Functions/FunctionGetDateData.h: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#include <Common/LocalDate.h> +#include <Common/DateLUT.h> +#include <Common/DateLUTImpl.h> +#include <Columns/ColumnString.h> +#include <Columns/ColumnVector.h> +#include <Columns/ColumnNullable.h> +#include <DataTypes/DataTypeNullable.h> +#include <Functions/FunctionFactory.h> +#include <IO/ReadBufferFromMemory.h> +#include <IO/ReadHelpers.h> +#include <IO/parseDateTimeBestEffort.h> + +using namespace DB; + +namespace DB +{ +namespace ErrorCodes +{ + extern const int ILLEGAL_TYPE_OF_ARGUMENT; + extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH; +} +} + +namespace local_engine +{ +template<bool get_year, bool get_date, typename T> +class FunctionGetDateData : public DB::IFunction +{ +public: + FunctionGetDateData() = default; + ~FunctionGetDateData() override = default; + bool checkAndGetDateData(DB::ReadBuffer & buf, size_t buf_size, T &x, const DateLUTImpl & date_lut, UInt8 & can_be_parsed) const + { + auto checkNumbericASCII = [&](DB::ReadBuffer & rb, size_t start, size_t length) -> bool + { + for (size_t i = start; i < start + length; ++i) + { + if (!isNumericASCII(*(rb.position() + i))) + { + return false; + } + } + return true; + }; + auto checkDelimiter = [&](DB::ReadBuffer & rb, size_t pos) -> bool + { + if (*(rb.position() + pos) != '-') + return false; + else + return true; + }; + bool yearNumberCanbeParsed = checkNumbericASCII(buf, 0, 4) && (buf_size == 4 || checkDelimiter(buf, 4)); + Int16 year = 0; + if (yearNumberCanbeParsed) + { + year = (*(buf.position() + 0) - '0') * 1000 + + (*(buf.position() + 1) - '0') * 100 + + (*(buf.position() + 2) - '0') * 10 + + (*(buf.position() + 3) - '0'); + x = get_year ? year : 0; + } + if (!yearNumberCanbeParsed + || !checkNumbericASCII(buf, 5, 2) + || !checkDelimiter(buf, 7) + || !checkNumbericASCII(buf, 8, 2)) + { + can_be_parsed = yearNumberCanbeParsed; + return false; + } + else + { + UInt8 month = (*(buf.position() + 5) - '0') * 10 + (*(buf.position() + 6) - '0'); + if (month <= 0 || month > 12) + return false; + UInt8 day = (*(buf.position() + 8) - '0') * 10 + (*(buf.position() + 9) - '0'); + if (day <= 0 || day > 31) + return false; + else if (day == 31 && (month == 2 || month == 4 || month == 6 || month == 9 || month == 11)) + return false; + else if (day == 30 && month == 2) + return false; + else + { + if (day == 29 && month == 2 && year % 4 != 0) + return false; + else + { + if (get_date) + x = date_lut.makeDayNum(year, month, day, -static_cast<Int32>(date_lut.getDayNumOffsetEpoch())); + return true; + } + } + } + } + + DB::ColumnPtr executeImpl(const DB::ColumnsWithTypeAndName & arguments, const DB::DataTypePtr & result_type, size_t) const override + { + if (arguments.size() != 1) + throw DB::Exception(DB::ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {}'s arguments number must be 1.", getName()); + + const DB::ColumnWithTypeAndName arg1 = arguments[0]; + const auto * src_col = checkAndGetColumn<DB::ColumnString>(arg1.column.get()); + size_t size = src_col->size(); + + if (!result_type->isNullable()) + throw DB::Exception(DB::ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT, "Function {}'s return type must be nullable", getName()); + + using ColVecTo = ColumnVector<T>; + typename ColVecTo::MutablePtr result_column = ColVecTo::create(size, 0); + typename ColVecTo::Container & result_container = result_column->getData(); + DB::ColumnUInt8::MutablePtr null_map = DB::ColumnUInt8::create(size, 0); + typename DB::ColumnUInt8::Container & null_container = null_map->getData(); + const DateLUTImpl * local_time_zone = &DateLUT::instance(); + const DateLUTImpl * utc_time_zone = &DateLUT::instance("UTC"); + + for (size_t i = 0; i < size; ++i) + { + auto str = src_col->getDataAt(i); + if (str.size < 4) + { + null_container[i] = true; + continue; + } + else + { + DB::ReadBufferFromMemory buf(str.data, str.size); + while(!buf.eof() && *buf.position() == ' ') + { + buf.position() ++; + } + if(buf.buffer().end() - buf.position() < 4) + { + null_container[i] = true; + continue; + } + UInt8 can_be_parsed = 1; Review Comment: use boolean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
