jackylee-ch commented on code in PR #5456:
URL: https://github.com/apache/incubator-gluten/pull/5456#discussion_r1592099409
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -1230,9 +1230,10 @@ object GlutenConfig {
val COLUMNAR_VELOX_CONNECTOR_IO_THREADS =
buildStaticConf("spark.gluten.sql.columnar.backend.velox.IOThreads")
.internal()
- .doc("The IO threads for connector split preloading")
+ .doc("The Size of the IO thread pool in the Connector. This thread pool
is used for split" +
+ " preloading and DirectBufferedInput.")
.intConf
- .createWithDefault(0)
+ .createWithDefaultFunction(() =>
SQLConf.get.getConfString("spark.executor.cores", "1").toInt)
Review Comment:
Does the IO Threads is related to the task num in one executor? The task num
in one executor is determined by `spark.executor.cores`/`spark.task.cpus`, so
we may get 8 IO Threads while there are only 4 tasks running in one executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
