zhztheplayer commented on code in PR #1202:
URL: https://github.com/apache/incubator-gluten/pull/1202#discussion_r1593580426
##########
gluten-core/src/main/scala/io/glutenproject/expression/ScalarSubqueryTransformer.scala:
##########
@@ -41,4 +47,16 @@ class ScalarSubqueryTransformer(plan: BaseSubqueryExec,
exprId: ExprId,
}
ExpressionBuilder.makeLiteral(result, query.dataType, result == null)
}
+
+ /**
+ * DataTypes which supported or not depend on actual value
+ *
+ * @param dataType
+ * @return
+ */
+ def valueSensitiveDataType(dataType: DataType): Boolean = {
+ dataType.isInstanceOf[MapType] ||
+ dataType.isInstanceOf[ArrayType] ||
+ dataType.isInstanceOf[StructType]
+ }
Review Comment:
Hi @loudongfeng , I just bumped into this code. Do you still remember the
reason of using this condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
