zhztheplayer commented on code in PR #5635:
URL: https://github.com/apache/incubator-gluten/pull/5635#discussion_r1594882896
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -208,7 +215,13 @@ int64_t
shrinkVeloxMemoryPool(velox::memory::MemoryManager* mm, velox::memory::M
} // namespace
const MemoryUsageStats VeloxMemoryManager::collectMemoryUsageStats() const {
- return collectMemoryUsageStatsInternal(veloxAggregatePool_.get());
+ MemoryUsageStats stats;
+ stats.set_current(listener_->currentBytes());
+ stats.set_peak(listener_->peakBytes());
+ stats.mutable_children()->emplace("gluten_allocator",
collectGlutenAllocatorMemoryUsageStats(glutenAlloc_.get()));
Review Comment:
Nit: Can it be better to use name `"gluten::MemoryAllocator"`? We have so
many `allocator` definitions so it's better to use a very specific identifier
to distinguish with others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
