This is an automated email from the ASF dual-hosted git repository.
yangzy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 949650969 [VL] Defer debug log generation (#5672)
949650969 is described below
commit 949650969d32d9149f438b856c27c6c609cd1946
Author: Yang Zhang <[email protected]>
AuthorDate: Thu May 9 20:40:15 2024 +0800
[VL] Defer debug log generation (#5672)
Memory dump message will be generated whether debug log enable or not, add
check to defer it and save cpu cycles.
---
.../gluten/memory/nmm/NativeMemoryManager.java | 30 ++++++++++++----------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git
a/gluten-data/src/main/java/org/apache/gluten/memory/nmm/NativeMemoryManager.java
b/gluten-data/src/main/java/org/apache/gluten/memory/nmm/NativeMemoryManager.java
index 95e9843be..230a7342e 100644
---
a/gluten-data/src/main/java/org/apache/gluten/memory/nmm/NativeMemoryManager.java
+++
b/gluten-data/src/main/java/org/apache/gluten/memory/nmm/NativeMemoryManager.java
@@ -95,20 +95,22 @@ public class NativeMemoryManager implements TaskResource {
@Override
public void release() throws Exception {
- LOGGER.debug(
- SparkMemoryUtil.prettyPrintStats(
- "About to release memory manager, usage dump:",
- new KnownNameAndStats() {
- @Override
- public String name() {
- return name;
- }
-
- @Override
- public MemoryUsageStats stats() {
- return collectMemoryUsage();
- }
- }));
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug(
+ SparkMemoryUtil.prettyPrintStats(
+ "About to release memory manager, usage dump:",
+ new KnownNameAndStats() {
+ @Override
+ public String name() {
+ return name;
+ }
+
+ @Override
+ public MemoryUsageStats stats() {
+ return collectMemoryUsage();
+ }
+ }));
+ }
release(nativeInstanceHandle);
if (listener.getUsedBytes() != 0) {
LOGGER.warn(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
