zhztheplayer commented on code in PR #5655:
URL: https://github.com/apache/incubator-gluten/pull/5655#discussion_r1596209504
##########
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala:
##########
@@ -106,15 +112,38 @@ class FallbackSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSparkPl
}
}
- // java.lang.NullPointerException
- ignore("fallback final aggregate of collect_list") {
+ test("fallback collect_list") {
+ withSQLConf(
+ GlutenConfig.EXPRESSION_BLACK_LIST.key -> "collect_list"
Review Comment:
One of the following tests is for partial fallback:
https://github.com/apache/incubator-gluten/pull/5655/files/c40a5ad359fe14b030f85627e0d983a2848c8bd6#diff-493b5fa71a5befc5adcd67b51e47e802b41870287619a7b752bbf85f53b1880cR139
Would you mean that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
