zhouyuan commented on code in PR #5675:
URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1596226525
##########
cpp/velox/shuffle/VeloxShuffleWriter.cc:
##########
@@ -376,8 +386,145 @@ arrow::Status
VeloxShuffleWriter::partitioningAndDoSplit(facebook::velox::RowVec
return arrow::Status::OK();
}
-arrow::Status VeloxShuffleWriter::stop() {
+arrow::Status VeloxShuffleWriter::doSort(facebook::velox::RowVectorPtr rv,
int64_t memLimit) {
+ currentInputColumnBytes_ += rv->estimateFlatSize();
+ batches_.push_back(rv);
Review Comment:
QQ: looks like this only enqueue the batches, the sort is done in Celeborn
side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
