zhouyifan279 commented on PR #5711: URL: https://github.com/apache/incubator-gluten/pull/5711#issuecomment-2106806866
> > @yma11 Did you reproduced the problem I mentioned above based on the master gluten branch? That is what I'm trying to fix. > > I mean which part of your code changes in this PR is the fix? Seems only some code refactor? Before this PR, `RowConstructorWithAllNullCallToSpecialForm.constructSpecialForm` was not called when function name was `row_constructor_with_all_null`. I think it was related to C++ overload/override mechanism. In this PR, I take function name as a member of `RowConstructorWithNullCallToSpecialForm` to avoid the overload/override issues and fix the result mismatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
