PHILO-HE commented on code in PR #5722:
URL: https://github.com/apache/incubator-gluten/pull/5722#discussion_r1598022007
##########
gluten-core/src/main/scala/org/apache/gluten/backendsapi/SparkPlanExecApi.scala:
##########
@@ -211,6 +211,13 @@ trait SparkPlanExecApi {
GenericExpressionTransformer(substraitExprName, Seq(), original)
}
+ def genShuffleTransformer(
+ substraitExprName: String,
+ child: ExpressionTransformer,
+ original: Shuffle): ExpressionTransformer = {
+ GenericExpressionTransformer(substraitExprName, Seq(child), original)
Review Comment:
Why not pass seed? I guess CH backend also needs the seed. Then, we can
remove genShuffleTransformer in API class.
cc @exmy, I note `shuffle` is mapped to `arrayshuffle` in CH. The doc says
it supports seed. See
https://clickhouse.com/docs/en/sql-reference/functions/array-functions#arrayshuffle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
