baibaichen commented on code in PR #5654:
URL: https://github.com/apache/incubator-gluten/pull/5654#discussion_r1598026841
##########
gluten-core/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala:
##########
@@ -492,7 +514,6 @@ object ExpressionConverter extends SQLConfHelper with
Logging {
expr.children.map(
replaceWithExpressionTransformerInternal(_, attributeSeq,
expressionsMap)),
expr)
-
case CheckOverflow(b: BinaryArithmetic, decimalType, _)
if !BackendsApiManager.getSettings.transformCheckOverflow &&
DecimalArithmeticUtil.isDecimalArithmetic(b) =>
Review Comment:
@jinchengchenghh if you update codes at the following
```scala
case b: BinaryArithmetic if
DecimalArithmeticUtil.isDecimalArithmetic(b) =>
DecimalArithmeticUtil.checkAllowDecimalArithmetic()
///...
```
The same logical should apply there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
