kerwin-zk commented on code in PR #5675:
URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1599288631
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -148,6 +149,69 @@ class JavaInputStreamAdaptor final : public
arrow::io::InputStream {
bool closed_ = false;
};
+class JavaInputStreamVeloxWrapper final : public JavaInputStreamWrapper {
Review Comment:
done
##########
cpp/velox/compute/VeloxRuntime.cc:
##########
@@ -243,8 +243,16 @@ std::shared_ptr<ShuffleReader>
VeloxRuntime::createShuffleReader(
auto codec = gluten::createArrowIpcCodec(options.compressionType,
options.codecBackend);
auto ctxVeloxPool = getLeafVeloxPool(memoryManager);
auto deserializerFactory =
std::make_unique<gluten::VeloxColumnarBatchDeserializerFactory>(
- schema, std::move(codec), rowType, options.batchSize, pool,
ctxVeloxPool);
- return std::make_shared<VeloxShuffleReader>(std::move(deserializerFactory));
+ schema,
+ std::move(codec),
+ options.compressionTypeStr,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
