gaoyangxiaozhu commented on code in PR #5351:
URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1599499474
##########
gluten-ut/spark34/src/test/scala/org/apache/gluten/utils/velox/VeloxTestSettings.scala:
##########
@@ -1188,12 +1190,6 @@ class VeloxTestSettings extends BackendTestSettings {
enableSuite[GlutenResolveDefaultColumnsSuite]
enableSuite[GlutenSubqueryHintPropagationSuite]
enableSuite[GlutenUrlFunctionsSuite]
- enableSuite[GlutenFileMetadataStructRowIndexSuite]
- // Row index metadata column support in Velox isn't ready yet, refer
velox-9147
- .exclude("reading _tmp_metadata_row_index - not present in a table")
- .exclude("reading _tmp_metadata_row_index - present in a table")
- // Row index metadata column support in Velox isn't ready yet, refer
velox-9147
- // enableSuite[GlutenParquetRowIndexSuite]
Review Comment:
@yma11 `GlutenParquetRowIndexSuite` fail with different reason, we should
know even the `row index metadata velox support` not fully ready yet, the
`GlutenParqutRowIndexSuite` should still be expected passed with fallback
strategy.
I have send another PR to enable `GlutenParquetRowIndexSuite`
https://github.com/apache/incubator-gluten/pull/5740
please help check.
Let make sure PR #5740 should be merged firstly before we process this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
