zhztheplayer commented on PR #5743: URL: https://github.com/apache/incubator-gluten/pull/5743#issuecomment-2111413019
I think there was some initial consideration about storing only general configurations in `cpp/core` as well as `GlutenConfig.h`. I do believe we don't yet have a very clear design for relationship between these Scala/CPP modules. But until we start a complete refactor, I think we can just follow the rules we already set so far. Regarding the change, I am inclined to not moving all confs to `GlutenConfig.h` (unless we have strong reason), but just moving [these Velox confs](https://github.com/apache/incubator-gluten/blob/37be4aa026c0aa9265a89fb7ae6b4210a1eaafed/cpp/core/config/GlutenConfig.h#L64-L69) from `cpp/core` to `cpp/velox`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
