kerwin-zk commented on code in PR #5675:
URL: https://github.com/apache/incubator-gluten/pull/5675#discussion_r1602507034
##########
cpp/velox/shuffle/VeloxShuffleWriter.h:
##########
@@ -132,6 +132,8 @@ class VeloxShuffleWriter final : public ShuffleWriter {
arrow::Status split(std::shared_ptr<ColumnarBatch> cb, int64_t memLimit)
override;
+ arrow::Status sort(std::shared_ptr<ColumnarBatch> cb, int64_t memLimit)
override;
Review Comment:
@marin-ma Shuffle Writer's api has been split into sort and hash, for
Shuffle Reader, it just adds Velox Stream parsing, and doesn't differentiate
between sort and hash, the core logic is the same, I don't feel the need to
split it out separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
