zhztheplayer commented on code in PR #5782:
URL: https://github.com/apache/incubator-gluten/pull/5782#discussion_r1604381360


##########
gluten-core/src/test/scala/org/apache/gluten/execution/WholeStageTransformerSuite.scala:
##########
@@ -252,6 +252,34 @@ abstract class WholeStageTransformerSuite
     assert(executedPlan.exists(plan => tag.runtimeClass.isInstance(plan)))
   }
 
+  /**
+   * Check whether the executed plan of a dataframe contains the expected plan 
chain.
+   *
+   * @param df
+   *   : the input dataframe.
+   * @param tag
+   *   : class of the expected plan.
+   * @param childTag
+   *   : class of the expected plan's child.
+   * @tparam T
+   *   : type of the expected plan.
+   * @tparam PT
+   *   : type of the expected plan's child.
+   */
+  def checkSparkOperatorChainMatch[T <: SparkPlan, PT <: SparkPlan](

Review Comment:
   Should we use `T <: UnaryExecNode` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to