xumingming commented on code in PR #5799:
URL: https://github.com/apache/incubator-gluten/pull/5799#discussion_r1606007070
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -580,17 +583,28 @@
Java_org_apache_gluten_vectorized_NativeColumnarToRowJniWrapper_nativeColumnarTo
JNIEnv* env,
jobject wrapper,
jlong batchHandle,
- jlong c2rHandle) {
+ jlong c2rHandle,
+ jlong rowId) {
JNI_METHOD_START
auto ctx = gluten::getRuntime(env, wrapper);
+ auto& conf = ctx->getConfMap();
+
auto columnarToRowConverter =
ctx->objectStore()->retrieve<ColumnarToRowConverter>(c2rHandle);
auto cb = ctx->objectStore()->retrieve<ColumnarBatch>(batchHandle);
- columnarToRowConverter->convert(cb);
+
+ int64_t column2RowMemThreshold = 200 * 1024 * 1024;
Review Comment:
nit: the default threshold on scala side is: `256 * 1024 * 1024`, keep the
default value same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
