gaoyangxiaozhu commented on PR #5856: URL: https://github.com/apache/incubator-gluten/pull/5856#issuecomment-2131029538
> > Right now, we only support for samling without replaceme > > Will Sampling with replacement (withReplacement is set to true) fallback? how complex if we add support to Velox? how useful it is? sample with relpacement allow pick up same row multiple times, that means it actually not simple filter but re-generating the data set, that is not worked by simple convert to a filter rand expression. I don't yet figur out a good way to supprot that part unless to make a new `sampleNode` in Velox side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
