zhztheplayer commented on code in PR #5874:
URL: https://github.com/apache/incubator-gluten/pull/5874#discussion_r1615413881
##########
cpp/core/jni/JniWrapper.cc:
##########
@@ -544,7 +544,12 @@ JNIEXPORT jlong JNICALL
Java_org_apache_gluten_vectorized_ColumnarBatchOutIterat
auto ctx = gluten::getRuntime(env, wrapper);
auto it = ctx->objectStore()->retrieve<ResultIterator>(iterHandle);
- return it->spillFixedSize(size);
+ if (it == nullptr) {
Review Comment:
`it == nullptr` is not that clear to indicate `it` is closed. Could we
leverage some kind of closing flags? Probably from Java / Scala side?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
