PHILO-HE commented on PR #5862: URL: https://github.com/apache/incubator-gluten/pull/5862#issuecomment-2132873983
> @PHILO-HE yes, I agree the convention in general.. The reason using `executeTransform` follows the Spark naming, like `executeColumnar -> doColumnar`, `executeBroadcast -> doBroadcast`. Please let me know what you prefer to. I note Spark's calling path is `executeColumnar -> doExecuteColumnar`. So it may be better to make Gluten's calling path become `transform` -> `doTransform` for better readability. https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
