gaoyangxiaozhu commented on code in PR #5351:
URL: https://github.com/apache/incubator-gluten/pull/5351#discussion_r1616670085


##########
shims/spark32/src/main/scala/org/apache/gluten/sql/shims/spark32/Spark32Shims.scala:
##########
@@ -189,8 +189,15 @@ class Spark32Shims extends SparkShims {
 
   def getFileStatus(partition: PartitionDirectory): Seq[FileStatus] = 
partition.files
 
+  def isFileSplittable(
+      relation: HadoopFsRelation,
+      filePath: Path,
+      sparkSchema: StructType): Boolean = true
+
   def isRowIndexMetadataColumn(name: String): Boolean = false
 
+  def findRowIndexColumnIndexInSchema(sparkSchema: StructType): Int = -1
+

Review Comment:
   `>=0` means found the index of `row index` column in schema, `-1` means not 
found



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to