Donvi opened a new issue, #5890: URL: https://github.com/apache/incubator-gluten/issues/5890
### Description Current the method signature is set with current plain text, which is not so good to maintain and read like "(J[J[II[B)V" and confusing for onboarding and in maintenance. The signature is generated by the parameter type list and the return value type. A better way is like below : 1. Build a map from type, which is via `typeid` in cpp, to signature 2. Create a method to generate the signature by the parameters type list and return type 3. Update the `getMethodIdOrError` from current signature to the parameter list and return type and call the method above 4. To make the above more readable and a better comprehensibility and encapsulation, we can declare a series variables to show the detailed meaning and pass it to the `getMethodIdOrError`. 5. Currently a draft PR for 1 and 2 are https://github.com/apache/incubator-gluten/pull/5888/files. I'll update the PR for step 3 and 4. cc: @zhouyuan , @zhztheplayer , @FelixYBW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
