ulysses-you commented on code in PR #5617:
URL: https://github.com/apache/incubator-gluten/pull/5617#discussion_r1618044481
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -208,7 +208,7 @@ class GlutenConfig(conf: SQLConf) extends Logging {
def queryFallbackThreshold: Int =
conf.getConf(COLUMNAR_QUERY_FALLBACK_THRESHOLD)
- def fallbackIgnoreRowToColumnar: Boolean =
conf.getConf(COLUMNAR_FALLBACK_IGNORE_ROW_TO_COLUMNAR)
+ def ignoreScanFallbackCost: Boolean =
conf.getConf(COLUMNAR_IGNORE_SCAN_FALLBACK_COST)
Review Comment:
@PHILO-HE the reason is that, we can some cases depend on this config. When
we set transitionCost=1 and enable `fallbackIgnoreRowToColumnar`, the
following query can be transformed since we ignore row to columnar.
```
ColumnarShuffle Shuffle
| |
\ RowToColumnar
\ /
JoinTransformer
```
If we drop `fallbackIgnoreRowToColumnar`, when transitionCost=1 is a way to
allow transforming this plan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
