rui-mo commented on code in PR #5750:
URL: https://github.com/apache/incubator-gluten/pull/5750#discussion_r1618121224
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxBackend.scala:
##########
@@ -376,13 +376,8 @@ object VeloxBackendSettings extends BackendSettingsApi {
} else {
t match {
// OPPRO-266: For Velox backend, build right and left are both
supported for
- // LeftOuter and LeftSemi.
- // FIXME Hongze 22/12/06
- // HashJoin.scala in shim was not always loaded by class loader.
- // The file should be removed and we temporarily disable the
improvement
- // introduced by OPPRO-266 by commenting out the following
prerequisite
- // condition.
-// case LeftOuter | LeftSemi => true
+ // LeftOuter.
+ case LeftOuter => true
Review Comment:
This function returns if building left is supported, which I assume
indicates the backend's capability and shouldn't be mixed up with the build
side selection.
> vanilla spark also choose build right.
It is due to some special logic, e.g. preferredBuildSide, Gluten chooses to
build left? If so, I think we need to fix there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
