jinchengchenghh commented on code in PR #5843:
URL: https://github.com/apache/incubator-gluten/pull/5843#discussion_r1618292291
##########
backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala:
##########
@@ -896,6 +896,32 @@ class TestOperator extends VeloxWholeStageTransformerSuite
with AdaptiveSparkPla
}
}
+ test("cast int as timestamp on velox") {
+ withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key -> "America/Los_Angeles") {
+ withTable("t") {
+ spark
+ .range(5)
+ .toDF("x")
+ .write
+ .format("parquet")
+ .saveAsTable("t")
+
+ runQueryAndCompare("select x, cast(x as timestamp) from t where cast(x
as timestamp) in (timestamp'1970-01-01 00:00:01UTC')") {df =>
checkFallbackOperators(df, 0)}
+ }
+ }
+ }
+
+ test("cast string as timestamp on velox") {
Review Comment:
same, because the tests is in backends-velox module
##########
backends-velox/src/test/scala/io/glutenproject/execution/TestOperator.scala:
##########
@@ -896,6 +896,32 @@ class TestOperator extends VeloxWholeStageTransformerSuite
with AdaptiveSparkPla
}
}
+ test("cast int as timestamp on velox") {
Review Comment:
Drop ` on velox`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
