ulysses-you commented on code in PR #5914:
URL: https://github.com/apache/incubator-gluten/pull/5914#discussion_r1620283224
##########
gluten-core/src/main/scala/org/apache/gluten/backendsapi/ListenerApi.scala:
##########
@@ -16,11 +16,11 @@
*/
package org.apache.gluten.backendsapi
-import org.apache.spark.SparkConf
+import org.apache.spark.{SparkConf, SparkContext}
trait ListenerApi {
- def onDriverStart(conf: SparkConf): Unit = {}
+ def onDriverStart(sc: SparkContext, conf: SparkConf): Unit = {}
def onDriverShutdown(): Unit = {}
- def onExecutorStart(conf: SparkConf): Unit = {}
+ def onExecutorStart(executorID: String, conf: SparkConf): Unit = {}
def onExecutorShutdown(): Unit = {}
Review Comment:
addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
