zzcclp commented on code in PR #230:
URL: https://github.com/apache/incubator-gluten/pull/230#discussion_r1628850760
##########
jvm/src/main/scala/io/glutenproject/extension/StrategyOverrides.scala:
##########
@@ -76,8 +69,26 @@ object JoinSelectionOverrides extends Strategy with
JoinSelectionHelper with SQL
if (GlutenConfig.getSessionConf.forceShuffledHashJoin) {
// Force use of ShuffledHashJoin in preference to SortMergeJoin. With
no respect to
// conf setting "spark.sql.join.preferSortMergeJoin".
- val leftBuildable = canBuildShuffledHashJoinLeft(joinType)
- val rightBuildable = canBuildShuffledHashJoinRight(joinType)
+ val (leftBuildable, rightBuildable) = if
(GlutenConfig.getConf.isClickHouseBackend) {
+ // Currently, ClickHouse backend can not support AQE, so it needs to
use join hint
+ // to decide the build side, after supporting AQE, will remove this.
Review Comment:
remove these comments please, it's not correct, now it already supports AQE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
