EpsilonPrime commented on code in PR #5398:
URL: https://github.com/apache/incubator-gluten/pull/5398#discussion_r1630694098
##########
gluten-core/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -495,6 +504,7 @@ message Rel {
GenerateRel generate = 17;
WriteRel write = 18;
TopNRel top_n = 19;
+ WindowGroupLimitRel windowGroupLimit = 20;
Review Comment:
Right now the this copy differs in about a half dozen ways from the original
project. A protobuf saved using this version will be loaded incorrectly since
DdlRel has field number 20. What should happen is that the differences
introduced here get applied back to the main project. I've started the process
of the CSV text format there. The Substrait project introduced
ConsistentPartitionWindowRel a while back (as field number 17) which may
actually do what you want here.
As long as you only talk to other consumers using this version of Substrait
your code will work. But you're missing out on the other tools. For instance,
the Substrait Validator is great for checking that you've constructed a
conforming plan. I run all of the plans generated by my end to end tests
through it and catches issues all the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
