zhztheplayer commented on PR #6009: URL: https://github.com/apache/incubator-gluten/pull/6009#issuecomment-2159625512
@XinShuoWang Do you have any thoughts on moving to this approach since https://github.com/apache/incubator-gluten/commit/ec3e92ec841ef71490c8c41c64647c60888e3885 has been merged? I don't have strong preference except that we need a configuration and metrics for batch-appending. I suggest merging this to make things configurable and displayable at first, then if we want to continue on https://github.com/apache/incubator-gluten/pull/5951 's approach, you can open another PR to bring the code back and re-use the conf code added in this patch. And remove calls to `maybeAddAppendBatchesExec` to disable AppendBatchesExec for shuffle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
