acvictor commented on code in PR #6022:
URL: https://github.com/apache/incubator-gluten/pull/6022#discussion_r1635842275
##########
backends-velox/src/test/scala/org/apache/gluten/execution/FallbackSuite.scala:
##########
@@ -71,6 +71,23 @@ class FallbackSuite extends VeloxWholeStageTransformerSuite
with AdaptiveSparkPl
collect(plan) { case v: VeloxColumnarToRowExec => v }.size
}
+ test("fallback with shuffle manager") {
+ withSQLConf(GlutenConfig.COLUMNAR_SHUFFLE_ENABLED.key -> "false") {
+ runQueryAndCompare("select c1, count(*) from tmp1 group by c1") {
+ df =>
+ val plan = df.queryExecution.executedPlan
+ val columnarShuffle = find(plan) {
+ case _: ColumnarShuffledJoin => true
Review Comment:
For the current query this is the plan
```
AdaptiveSparkPlan isFinalPlan=true
+- == Final Plan ==
VeloxColumnarToRowExec
+- ^(6) HashAggregateTransformer(keys=[c1#14], functions=[count(1)],
output=[c1#14, count(1)#26L])
+- ^(6) InputIteratorTransformer[c1#14, count#30L]
+- ^(6) InputAdapter
+- ^(6) RowToVeloxColumnar
+- ^(6) AQEShuffleRead coalesced
+- ^(6) ShuffleQueryStage 0
+- Exchange hashpartitioning(c1#14, 5),
ENSURE_REQUIREMENTS, [plan_id=281]
+- VeloxColumnarToRowExec
+- ^(5) HashAggregateTransformer(keys=[c1#14],
functions=[partial_count(1)], output=[c1#14, count#30L])
+- ^(5) NativeFileScan parquet
spark_catalog.default.tmp11111[c1#14] Batched: true, DataFilters: [], Format:
Parquet, Location: InMemoryFileIndex(1
paths)[file:/home/anvicto/src/Gluten/spark-warehouse/org.apache.gluten.execut...,
PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c1:int>
```
Can I retain it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
