yma11 commented on code in PR #6038:
URL: https://github.com/apache/incubator-gluten/pull/6038#discussion_r1635922201
##########
cpp/velox/udf/Udaf.h:
##########
@@ -23,7 +23,7 @@ struct UdafEntry {
const char* name;
const char* dataType;
- size_t numArgs;
+ int numArgs;
Review Comment:
Will this change matter? I see velox uses `uint32_t` in some places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
