WangGuangxin commented on code in PR #5966:
URL: https://github.com/apache/incubator-gluten/pull/5966#discussion_r1636060480
##########
cpp/velox/substrait/SubstraitToVeloxPlan.h:
##########
@@ -479,13 +494,14 @@ class SubstraitToVeloxPlanConverter {
template <TypeKind KIND, typename FilterType>
void createNotEqualFilter(variant notVariant, bool nullAllowed,
std::vector<std::unique_ptr<FilterType>>& colFilters);
- /// Create a values range to handle in filter.
- /// variants: the list of values extracted from the in expression.
+ /// Create a values range to handle (not) in filter.
+ /// variants: the list of values extracted from the (not) in expression.
Review Comment:
yes, add comments for this param
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
