zml1206 commented on PR #6048:
URL: 
https://github.com/apache/incubator-gluten/pull/6048#issuecomment-2164250165

   > @zml1206 why not pass prefer build side to ShuffledHashJoinExecTransformer 
directly ? BTW, if it will eventually be eliminated, why the golden files 
changed ?
   
   What I hope is that both creates "more vanilla" plan when the join operators 
are falling back and builds buildsideide with small tables. Prefer build side 
to ShuffledHashJoinExecTransformer directly is not always possible to select a 
smaller table. For example, before AQE is SortMergeJoin, the sizeByte on the 
left is small. During AQE, it is still SortMergeJoin. The sizeByte on the right 
is small. However, because the plan has not changed, the plan will not be 
replaced. In the end, the left table is selected.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to