zhouyifan279 commented on code in PR #6073:
URL: https://github.com/apache/incubator-gluten/pull/6073#discussion_r1639311132
##########
ep/build-velox/src/get_velox.sh:
##########
@@ -106,15 +106,15 @@ function process_setup_ubuntu {
fi
sed -i "s/apt install -y/sudo apt install -y/"
${VELOX_HOME}/scripts/setup-adapters.sh
if [ $ENABLE_S3 == "ON" ]; then
- sed -i '/^ run_and_time install_folly/a \ \
'${VELOX_HOME}/scripts'/setup-adapters.sh aws' scripts/setup-ubuntu.sh
+ sed -i '/^ run_and_time install_folly/a \ \ SUDO=$SUDO
'${VELOX_HOME}/scripts'/setup-adapters.sh aws' scripts/setup-ubuntu.sh
Review Comment:
Use `SUDO=$SUDO <command>` instead of `export SUDO <command>`. So env `SUDO`
is only passed to current command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
