ulysses-you commented on code in PR #6093:
URL: https://github.com/apache/incubator-gluten/pull/6093#discussion_r1639545987
##########
gluten-core/src/main/scala/org/apache/gluten/extension/columnar/TransformHintRule.scala:
##########
@@ -416,16 +387,7 @@ case class AddTransformHintRule() extends Rule[SparkPlan] {
val transformer = ColumnarShuffleExchangeExec(plan, plan.child,
plan.child.output)
transformer.doValidate().tagOnFallback(plan)
case plan: ShuffledHashJoinExec =>
- val transformer = BackendsApiManager.getSparkPlanExecApiInstance
- .genShuffledHashJoinExecTransformer(
- plan.leftKeys,
- plan.rightKeys,
- plan.joinType,
- TransformHints.getShuffleHashJoinBuildSide(plan),
Review Comment:
It seems we have already chosen a small table before. The only thing
different with before is, we convert smj to shj from strategy to columnar, so
is GlutenCostEvaluator required ? I think the cost evaluator is useful when we
add tag in strategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
