baibaichen commented on code in PR #6069:
URL: https://github.com/apache/incubator-gluten/pull/6069#discussion_r1641177848
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHIteratorApi.scala:
##########
@@ -43,6 +43,7 @@ import java.util.{ArrayList => JArrayList, HashMap =>
JHashMap, Map => JMap}
import scala.collection.JavaConverters._
import scala.collection.mutable.ArrayBuffer
+import scala.language.reflectiveCalls
Review Comment:
`genFirstStageIterator` 里的 `val iter = new Iterator[Any]` 和
`genFinalStageIterator` 里的 `val resIter = new Iterator[ColumnarBatch]`
基本重复，主要区别就是是否 `updateInputMetrics(inputMetrics)`，如果这里新建一个
`CollectMetricItertor`，一方面可以去除重复代码，另一方面应该可以不用 `import
scala.language.reflectiveCalls`，下图是我改了变量名之后的 diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
