yma11 commented on code in PR #5660:
URL: https://github.com/apache/incubator-gluten/pull/5660#discussion_r1645272377
##########
shims/common/src/main/scala/org/apache/gluten/GlutenConfig.scala:
##########
@@ -687,6 +699,10 @@ object GlutenConfig {
(SPARK_S3_USE_INSTANCE_CREDENTIALS, "false"),
(SPARK_S3_IAM, ""),
(SPARK_S3_IAM_SESSION_NAME, ""),
+ (SPARK_S3_RETRY_MAX_ATTEMPTS, "3"),
+ (SPARK_S3_CONNECTION_MAXIMUM, "96"),
Review Comment:
Yes. These keys can also use `defaultValueString` but existing code also use
the value directly for easy reading unless it's a new config in gluten itself.
So let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
