This is an automated email from the ASF dual-hosted git repository.
zhli pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 3e5b54e64 [VL] Fix greatest and least function tests (#6209)
3e5b54e64 is described below
commit 3e5b54e64032ab3e860c1636ab4760557a8a1e96
Author: Zhen Li <[email protected]>
AuthorDate: Tue Jun 25 19:15:55 2024 +0800
[VL] Fix greatest and least function tests (#6209)
[VL] Fix greatest and least function tests.
---
.../execution/ScalarFunctionsValidateSuite.scala | 44 ++++++++++++++++------
1 file changed, 32 insertions(+), 12 deletions(-)
diff --git
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
index 75b60addf..a2baf95ec 100644
---
a/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
+++
b/backends-velox/src/test/scala/org/apache/gluten/execution/ScalarFunctionsValidateSuite.scala
@@ -157,24 +157,28 @@ class ScalarFunctionsValidateSuite extends
FunctionsValidateTest {
checkLengthAndPlan(df, 1)
}
- test("greatest function") {
- val df = runQueryAndCompare(
- "SELECT greatest(l_orderkey, l_orderkey)" +
- "from lineitem limit
1")(checkGlutenOperatorMatch[ProjectExecTransformer])
- }
-
- test("least function") {
- val df = runQueryAndCompare(
- "SELECT least(l_orderkey, l_orderkey)" +
- "from lineitem limit
1")(checkGlutenOperatorMatch[ProjectExecTransformer])
- }
-
test("Test greatest function") {
runQueryAndCompare(
"SELECT greatest(l_orderkey, l_orderkey)" +
"from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
+ withTempPath {
+ path =>
+ spark
+ .sql("""SELECT *
+ FROM VALUES (CAST(5.345 AS DECIMAL(6, 2)), CAST(5.35 AS
DECIMAL(5, 4))),
+ (CAST(5.315 AS DECIMAL(6, 2)), CAST(5.355 AS DECIMAL(5, 4))),
+ (CAST(3.345 AS DECIMAL(6, 2)), CAST(4.35 AS DECIMAL(5, 4))) AS
data(a, b);""")
+ .write
+ .parquet(path.getCanonicalPath)
+
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+
+ runQueryAndCompare("SELECT greatest(a, b) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
}
test("Test least function") {
@@ -183,6 +187,22 @@ class ScalarFunctionsValidateSuite extends
FunctionsValidateTest {
"from lineitem limit 1") {
checkGlutenOperatorMatch[ProjectExecTransformer]
}
+ withTempPath {
+ path =>
+ spark
+ .sql("""SELECT *
+ FROM VALUES (CAST(5.345 AS DECIMAL(6, 2)), CAST(5.35 AS
DECIMAL(5, 4))),
+ (CAST(5.315 AS DECIMAL(6, 2)), CAST(5.355 AS DECIMAL(5, 4))),
+ (CAST(3.345 AS DECIMAL(6, 2)), CAST(4.35 AS DECIMAL(5, 4))) AS
data(a, b);""")
+ .write
+ .parquet(path.getCanonicalPath)
+
+
spark.read.parquet(path.getCanonicalPath).createOrReplaceTempView("view")
+
+ runQueryAndCompare("SELECT least(a, b) from view") {
+ checkGlutenOperatorMatch[ProjectExecTransformer]
+ }
+ }
}
test("Test hash function") {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
